Prev: [PATCH 1/2] perf: Version String fix, using kernel version
Next: [PATCH 2/2] perf: Version String fix, for fallback if not from git
From: Kulikov Vasiliy on 5 Jul 2010 04:10
Clone checking of ret to simplify the code.

This patch silences a compiler warning:
drivers/bluetooth/btmrvl_sdio.c: In function 'btmrvl_sdio_verify_fw_download':
drivers/bluetooth/btmrvl_sdio.c:80: warning: 'fws1' may be used uninitialized in this function
drivers/bluetooth/btmrvl_sdio.c:80: note: 'fws1' was declared here

Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
---
drivers/bluetooth/btmrvl_sdio.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index df0773e..47f0f91 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -83,10 +83,10 @@ static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
*dat = 0;

fws0 = sdio_readb(card->func, CARD_FW_STATUS0_REG, &ret);
+ if (ret)
+ return -EIO;

- if (!ret)
- fws1 = sdio_readb(card->func, CARD_FW_STATUS1_REG, &ret);
-
+ fws1 = sdio_readb(card->func, CARD_FW_STATUS1_REG, &ret);
if (ret)
return -EIO;

--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/2] perf: Version String fix, using kernel version
Next: [PATCH 2/2] perf: Version String fix, for fallback if not from git