[PATCH] checkpatch: Add warnings for use of mdelay()
in [Kernel]
|
Prev: PCI / PCIe: Ask BIOS for control of all native services simultaneously
Next: [PATCH 2/9] xen: Allow unprivileged Xen domains to create iomap pages
From: Israel Schlesinger on 27 Jul 2010 13:20 mdelay is a busy-wait loop which is wasteful. If at all possible, callers should use msleep instead of mdelay. The only time mdelay is really appropriate is in atomic context, however, delays of 1ms+ in atomic context are rather expensive, so a warning for this case is probably appropriate as well to encourage people to move such expensive delays outside of atomic context Signed-off-by: Israel Schlesinger <israels(a)codeaurora.org> --- scripts/checkpatch.pl | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd88f11..b3f7f71 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2570,6 +2570,11 @@ sub process { } } +# check the patch for use of mdelay + if ($line =~ /\bmdelay\(/) { + WARN("use of mdelay() found: msleep() is the preferred API.\n" . $line ); + } + # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { # print "#ifdef in C files should be avoided\n"; -- 1.7.0.2 -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |