Prev: [PATCH V2] [X86] Fix potential issue on memmove
Next: [PATCH] nfs: lookupcache coherence bugs in WCC update path (revised)
From: Rabin Vincent on 12 Aug 2010 01:20
Throw an error when a source file has been given execute permissions
using the mode change line present in git diffs. Also alow the filename
matching to use the "diff" line in addition to the "+++" line, since the
mode change lines appear before any "+++" lines.

Cc: Andy Whitcroft <apw(a)canonical.com>
Acked-by: Linus Walleij <linus.walleij(a)stericsson.com>
Signed-off-by: Rabin Vincent <rabin.vincent(a)stericsson.com>
---
scripts/checkpatch.pl | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2039acd..4c35cb9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1308,7 +1308,7 @@ sub process {
$here = "#$realline: " if ($file);

# extract the filename as it passes
- if ($line=~/^\+\+\+\s+(\S+)/) {
+ if ($line=~/^\+\+\+\s+(\S+)/ || $line=~/^diff\s.*?(\S+)$/) {
$realfile = $1;
$realfile =~ s@^([^/]*)/@@;

@@ -1332,6 +1332,14 @@ sub process {

$cnt_lines++ if ($realcnt != 0);

+# Check for incorrect file permissions
+ if ($line=~/^new (file )?mode.*[7531]\d{0,2}$/) {
+ my $permhere = $here . "FILE: $realfile\n";
+ if ($realfile=~/(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
+ ERROR("do not set execute permissions for source files\n" . $permhere);
+ }
+ }
+
#check the patch for a signoff:
if ($line =~ /^\s*signed-off-by:/i) {
# This is a signoff, if ugly, so do not double report.
--
1.7.2.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH V2] [X86] Fix potential issue on memmove
Next: [PATCH] nfs: lookupcache coherence bugs in WCC update path (revised)