[PATCH] checkpatch: fix false positive on casting to double pointer
in [Kernel]
|
Prev: patch tty-remove-hayes-esp-ioctls.patch added to gregkh-2.6 tree
Next: weird umem vs nfsd regression
From: Scott J. Goldman on 17 Jun 2010 16:30 Signed-off-by: Scott J. Goldman <scottjg(a)vmware.com> --- scripts/checkpatch.pl | 4 +++- tests/t/t9190-double-pointers | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletions(-) create mode 100644 tests/t/t9190-double-pointers diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 87bbb8b..687bd6f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1982,7 +1982,9 @@ sub process { $op eq '*' or $op eq '/' or $op eq '%') { - if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { + if ($op eq '*' && $cc =~ /^\*/) { + # double pointer is ok + } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { ERROR("need consistent spacing around '$op' $at\n" . $hereptr); } diff --git a/tests/t/t9190-double-pointers b/tests/t/t9190-double-pointers new file mode 100644 index 0000000..3f3f7f9 --- /dev/null +++ b/tests/t/t9190-double-pointers @@ -0,0 +1,6 @@ +pass "foo **x;" +pass "x = **y;" +pass "x = (foo **)y;" + +err='"(foo ** )" should be "(foo **)"' +fail "x = (foo ** )y;" "$err" -- 1.6.0.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |