Prev: [PATCH]: cleanup debug message in irq_to_desc_alloc_node()
Next: [PATCH] LEDS: fix race between LED device uevent and actual attributes creation
From: Prarit Bhargava on 10 Mar 2010 09:10
Cleanup a debug message in init_kstat_irqs().

This debug message can result in valid output like

alloc kstat_irqs on node -1

which looks alot like an error message.

This debug statement has been in the kernel for over a year, so I think it is
safe to remove it and report the node in only the error case instead.

Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 76d5a67..e7fb871 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
* don't overwite if can not get new one
* init_copy_kstat_irqs() could still use old one
*/
- if (ptr) {
- printk(KERN_DEBUG " alloc kstat_irqs on node %d\n", node);
+ if (ptr)
desc->kstat_irqs = ptr;
- }
+ else
+ printk(KERN_ERR " alloc kstat_irqs on node %d failed\n", node);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH]: cleanup debug message in irq_to_desc_alloc_node()
Next: [PATCH] LEDS: fix race between LED device uevent and actual attributes creation