[PATCH] dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit
in [Kernel]
|
Prev: KVM: VMX: fix tlb flush with invalid root
Next: [ANNOUNCE] MDB Merkey's Kernel Debugger x86_64 2.6.34 07-04-2010 Release 6
From: Axel Lin on 4 Jul 2010 21:40 >From 03828286561e3d39cacfb831b2f303a047a6f787 Mon Sep 17 00:00:00 2001 From: Axel Lin <axel.lin(a)gmail.com> Date: Mon, 5 Jul 2010 09:26:30 +0800 Subject: [PATCH] dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit smi_data_buf_free is called twice in current implementation. The second call simply return because smi_data_buf is set to NULL in first call. This patch removes the second smi_data_buf_free call. Signed-off-by: Axel Lin <axel.lin(a)gmail.com> --- drivers/firmware/dcdbas.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index aa9bc9e..69ad529 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c @@ -634,9 +634,6 @@ static void __exit dcdbas_exit(void) * before platform_device_unregister */ unregister_reboot_notifier(&dcdbas_reboot_nb); - smi_data_buf_free(); - platform_device_unregister(dcdbas_pdev); - platform_driver_unregister(&dcdbas_driver); /* * We have to free the buffer here instead of dcdbas_remove @@ -645,6 +642,8 @@ static void __exit dcdbas_exit(void) * released. */ smi_data_buf_free(); + platform_device_unregister(dcdbas_pdev); + platform_driver_unregister(&dcdbas_driver); } module_init(dcdbas_init); -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |