Prev: mtd/nand/r852: fix build for CONFIG_PCI disabled
Next: [PATCH] perf_events: remove bogus Intel Core constraint on ITLB_MISS_RETIRED
From: Eric Dumazet on 11 Mar 2010 16:00
In case of kvasprintf() failure, we can leak old kobject name.

Signed-off-by: Eric Dumazet <eric.dumazet(a)gmail.com>
---
diff --git a/lib/kobject.c b/lib/kobject.c
index 8115eb1..1247c57 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
return 0;

kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
- if (!kobj->name)
+ if (!kobj->name) {
+ kobj->name = old_name;
return -ENOMEM;
+ }

/* ewww... some of these buggers have '/' in the name ... */
while ((s = strchr(kobj->name, '/')))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: mtd/nand/r852: fix build for CONFIG_PCI disabled
Next: [PATCH] perf_events: remove bogus Intel Core constraint on ITLB_MISS_RETIRED