Prev: [patch 3/5] mincore: pass ranges as start,end address pairs
Next: [PATCH -mm 1/2] proc_sched_show_task: use get_nr_threads()
From: Jens Rottmann on 23 Mar 2010 10:40
ksz884x: fix return value of netdev_set_eeprom

netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.

Signed-off-by: Jens Rottmann <JRottmann(a)LiPPERTEmbedded.de>
---

--- linux-2.6.34-rc2-git1/drivers/net/ksz884x.c
+++ return_value_fixed/drivers/net/ksz884x.c
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_
int len;

if (eeprom->magic != EEPROM_MAGIC)
- return 1;
+ return -EINVAL;

len = (eeprom->offset + eeprom->len + 1) / 2;
for (i = eeprom->offset / 2; i < len; i++)
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [patch 3/5] mincore: pass ranges as start,end address pairs
Next: [PATCH -mm 1/2] proc_sched_show_task: use get_nr_threads()