Prev: [PATCH] mtd: Do not corrupt backing device for inode
Next: [PATCH 1/2] Composite framework: Add suspended sysfs entry
From: Rabin Vincent on 21 Apr 2010 11:40
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Rabin Vincent <rabin(a)rab.in>
---
drivers/mfd/wm8350-i2c.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c
index 65830f5..5fe5de1 100644
--- a/drivers/mfd/wm8350-i2c.c
+++ b/drivers/mfd/wm8350-i2c.c
@@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
int ret = 0;

wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
- if (wm8350 == NULL) {
- kfree(i2c);
+ if (wm8350 == NULL)
return -ENOMEM;
- }

i2c_set_clientdata(i2c, wm8350);
wm8350->dev = &i2c->dev;
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] mtd: Do not corrupt backing device for inode
Next: [PATCH 1/2] Composite framework: Add suspended sysfs entry