Prev: [PATCH -mm 02/17] sysctl extern cleanup - signal
Next: [PATCH -mm 10/17] sysctl extern cleanup - block iopoll
From: Dave Young on 21 Feb 2010 09:30 Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files. Move inotify_table extern declaration to linux/inotify.h Signed-off-by: Dave Young <hidave.darkstar(a)gmail.com> --- include/linux/inotify.h | 5 +++++ kernel/sysctl.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) --- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 11:25:35.455865983 +0800 +++ linux-2.6.32/kernel/sysctl.c 2010-02-21 11:27:43.782519869 +0800 @@ -75,6 +75,9 @@ #ifdef CONFIG_EPOLL #include <linux/poll.h> #endif +#ifdef CONFIG_INOTIFY_USER +#include <linux/inotify.h> +#endif #ifdef CONFIG_CHR_DEV_SG #include <scsi/sg.h> #endif @@ -174,9 +177,6 @@ static struct ctl_table fs_table[]; static struct ctl_table debug_table[]; static struct ctl_table dev_table[]; extern struct ctl_table random_table[]; -#ifdef CONFIG_INOTIFY_USER -extern struct ctl_table inotify_table[]; -#endif /* The default sysctl tables: */ --- linux-2.6.32.orig/include/linux/inotify.h 2010-02-21 11:25:35.465866403 +0800 +++ linux-2.6.32/include/linux/inotify.h 2010-02-21 11:28:20.686684371 +0800 @@ -69,4 +69,9 @@ struct inotify_event { #define IN_CLOEXEC O_CLOEXEC #define IN_NONBLOCK O_NONBLOCK +#ifdef __KERNEL__ +#include <linux/sysctl.h> +extern struct ctl_table inotify_table[]; /* for sysctl */ +#endif + #endif /* _LINUX_INOTIFY_H */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |