Prev: No definition of trace_sched_stat_wait in kernel found!
Next: Driver: PCIe: 'pci_map_sg' returning invalid bus address?
From: Joe Perches on 28 Jul 2010 06:10
On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote:
> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote:
> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
> > total: 2 errors, 25 warnings, 1723 lines checked
> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
> > total: 0 errors, 0 warnings, 1743 lines checked
> i dislike the mixing of whitespace and useful changes
> if they were split, and they worked, then i wouldnt have a problem with them

Is that a nak or a dislike?

Also, is Michael Hennerich actually the maintainer for bfin_mac?
He had been listed as MAINTAINER for over a year but he hasn't
ever written or acked a patch for this file.

commit making Michael Hennerich bfin_mac MAINTAINER
$ git log -1 6c83429a
commit 6c83429a1c32c914dfb81939cc2ddece97e48294
Author: Mike Frysinger <vapier(a)gentoo.org>
Date: Sun May 24 02:13:15 2009 -0400

MAINTAINERS: update Blackfin items

With Bryan Wu having moved on to another job, push the slack onto some
other ADI lackeys.

Signed-off-by: Mike Frysinger <vapier(a)gentoo.org>

$ ./scripts/get_maintainer.pl -f drivers/net/bfin_mac.c \
--rolestats --git-since=5-years-ago --nol
Michael Hennerich <michael.hennerich(a)analog.com> (supporter:BLACKFIN EMAC DRIVER)
"David S. Miller" <davem(a)davemloft.net> (commit_signer:41/65=63%)
Jeff Garzik <jgarzik(a)redhat.com> (commit_signer:31/65=48%)
Bryan Wu <cooloney(a)kernel.org> (commit_signer:26/65=40%)
Mike Frysinger <vapier(a)gentoo.org> (commit_signer:20/65=31%)
Sonic Zhang <sonic.zhang(a)analog.com> (commit_signer:8/65=12%)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Hennerich, Michael on 28 Jul 2010 06:50
Joe Perches wrote on 2010-07-28:
> On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote:
>> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote:
>>> $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
>>> total: 2 errors, 25 warnings, 1723 lines checked $
>>> ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:"
>>> total: 0 errors, 0 warnings, 1743 lines checked
>> i dislike the mixing of whitespace and useful changes if they were
>> split, and they worked, then i wouldnt have a problem with them
>
> Is that a nak or a dislike?

I think what Mike meant was - two patches would be better.
I'm currently cloning the tree this patch applies to.
I'll ACK once I verified the patch.

>
> Also, is Michael Hennerich actually the maintainer for bfin_mac?
> He had been listed as MAINTAINER for over a year but he hasn't ever
> written or acked a patch for this file.
>
> commit making Michael Hennerich bfin_mac MAINTAINER $ git log -1
> 6c83429a commit 6c83429a1c32c914dfb81939cc2ddece97e48294
> Author: Mike Frysinger <vapier(a)gentoo.org>
> Date: Sun May 24 02:13:15 2009 -0400
>
> MAINTAINERS: update Blackfin items
>
> With Bryan Wu having moved on to another job, push the slack onto
> some other ADI lackeys.
>
> Signed-off-by: Mike Frysinger <vapier(a)gentoo.org>
> $ ./scripts/get_maintainer.pl -f drivers/net/bfin_mac.c \
> --rolestats --git-since=5-years-ago --nol Michael Hennerich
> <michael.hennerich(a)analog.com> (supporter:BLACKFIN EMAC DRIVER) "David
> S. Miller" <davem(a)davemloft.net> (commit_signer:41/65=63%) Jeff Garzik
> <jgarzik(a)redhat.com> (commit_signer:31/65=48%) Bryan Wu
> <cooloney(a)kernel.org> (commit_signer:26/65=40%) Mike Frysinger
> <vapier(a)gentoo.org> (commit_signer:20/65=31%) Sonic Zhang
> <sonic.zhang(a)analog.com> (commit_signer:8/65=12%)
>
>

Greetings,
Michael

Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif


 | 
Pages: 1
Prev: No definition of trace_sched_stat_wait in kernel found!
Next: Driver: PCIe: 'pci_map_sg' returning invalid bus address?