From: Joonyoung Shim on 5 Aug 2010 22:10 The enable time needs to enable WM8994 LDO, but WM8994 LDO is enabled without the enable time at the probe function. This can cause the problem to try i2c operation before LDO is enabled. This patch sets to 0 WM8994 LDO enable gpio when probed then if it is requested to enable WM8994 LDO, will be enabled by enable interface of regulator core with enable time. Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> --- drivers/regulator/wm8994-regulator.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c index 5a1dc8a..03713bc 100644 --- a/drivers/regulator/wm8994-regulator.c +++ b/drivers/regulator/wm8994-regulator.c @@ -219,8 +219,6 @@ static __devinit int wm8994_ldo_probe(struct platform_device *pdev) ldo->wm8994 = wm8994; - ldo->is_enabled = true; - if (pdata->ldo[id].enable && gpio_is_valid(pdata->ldo[id].enable)) { ldo->enable = pdata->ldo[id].enable; @@ -237,7 +235,8 @@ static __devinit int wm8994_ldo_probe(struct platform_device *pdev) ret); goto err_gpio; } - } + } else + ldo->is_enabled = true; ldo->regulator = regulator_register(&wm8994_ldo_desc[id], &pdev->dev, pdata->ldo[id].init_data, ldo); -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [GIT PULL] viafb updates Next: [PATCH 2/2] DNS: Fixes for the DNS query module |