Prev: 2.6.34 echo j > /proc/sysrq-trigger causes inifnite unfreeze/Thaw event
Next: (none)
From: Baruch Siach on 7 Jun 2010 01:00
Hi Wan,

On Sat, Jun 05, 2010 at 11:08:46PM +0800, Wan ZongShun wrote:
> Some minor comments below:

Thank you very much for you review and comments. I'll address your comments
(and Andrew's), and send an update shortly.

> Are local_irq_disable() and al_irq_enable() necessary?
>
> RTC 'rtc_update_irq' seem to have called 'spin_lock_irqsave' , where
> local irq will be disable.

You're right. Since commit e6229bec25be4ba00f31dd26e25721cc96c22262
rtc_update_irq can be called with irqs enabled.

baruch

--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch(a)tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Baruch Siach on 7 Jun 2010 01:30
Hi Wan,

On Sat, Jun 05, 2010 at 11:08:46PM +0800, Wan ZongShun wrote:
> Some minor comments below:

One question though.

> > +/*
> > + * read the seconds portion of the current time from the dryice time counter
> > + */
> > +static int dryice_rtc_read_time(struct device *dev, struct rtc_time *tm)
> > +{
> > + � � � struct imxdi_dev *imxdi = dev_get_drvdata(dev);
> > + � � � unsigned long now;
> > +
> > + � � � now = __raw_readl(imxdi->ioaddr + DTCMR);
> > + � � � rtc_time_to_tm(now, tm);
> > +
>
> When we want to return a tm value, call rtc_valid_tm() to check the tm
> that is a good habit.

Isn't rtc_time_to_tm() guaranteed to produce a valid tm value?

>
> > + � � � return 0;
> > +}

baruch

--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch(a)tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: 2.6.34 echo j > /proc/sysrq-trigger causes inifnite unfreeze/Thaw event
Next: (none)