Prev: maureen clark
Next: [PATCH 0/9] Suspend block api (version 5)
From: Changli Gao on 28 Apr 2010 00:20
use wrapper functions.

Since there are add_wait_queue_exclusive_locked() and remove_wait_queue_locked()
, we'd better use them instead.

Signed-off-by: Changli Gao <xiaosuo(a)gmail.com>
----
kernel/sched.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 6af210a..be5ab70 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4039,8 +4039,7 @@ do_wait_for_common(struct completion *x, long timeout, int state)
if (!x->done) {
DECLARE_WAITQUEUE(wait, current);

- wait.flags |= WQ_FLAG_EXCLUSIVE;
- __add_wait_queue_tail(&x->wait, &wait);
+ add_wait_queue_exclusive_locked(&x->wait, &wait);
do {
if (signal_pending_state(state, current)) {
timeout = -ERESTARTSYS;
@@ -4051,7 +4050,7 @@ do_wait_for_common(struct completion *x, long timeout, int state)
timeout = schedule_timeout(timeout);
spin_lock_irq(&x->wait.lock);
} while (!x->done && timeout);
- __remove_wait_queue(&x->wait, &wait);
+ remove_wait_queue_locked(&x->wait, &wait);
if (!x->done)
return timeout;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: maureen clark
Next: [PATCH 0/9] Suspend block api (version 5)