Prev: [GIT PULL] sound updates for 2.6.34-rc1
Next: [PATCH] serial: Add OMAP high-speed UART driver.
From: Alessio Igor Bogani on 1 Mar 2010 08:20
Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.

Also change the returned value to long.

Signed-off-by: Alessio Igor Bogani <abogani(a)texware.it>
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 8b37a4b..b0746c3 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -2964,13 +2964,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct sisusb_usb_data *sisusb;
struct sisusb_info x;
struct sisusb_command y;
- int retval = 0;
+ long retval = 0;
u32 __user *argp = (u32 __user *)arg;

if (!(sisusb = (struct sisusb_usb_data *)file->private_data))
return -ENODEV;

- lock_kernel();
mutex_lock(&sisusb->lock);

/* Sanity check */
@@ -3029,7 +3028,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)

err_out:
mutex_unlock(&sisusb->lock);
- unlock_kernel();
return retval;
}

--
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [GIT PULL] sound updates for 2.6.34-rc1
Next: [PATCH] serial: Add OMAP high-speed UART driver.