Prev: arch/microblaze: Removing dead CONTIGUOUS_PAGE_ALLOC config option
Next: [PATCH] staging: adis16255: fix sysfs leak
From: Kulikov Vasiliy on 11 Aug 2010 04:10
Original code doesn't call kfree(chip) on error.

Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
---
drivers/staging/tm6000/tm6000-alsa.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c
index 087137d..6c09ef3 100644
--- a/drivers/staging/tm6000/tm6000-alsa.c
+++ b/drivers/staging/tm6000/tm6000-alsa.c
@@ -403,7 +403,7 @@ int tm6000_audio_init(struct tm6000_core *dev)

rc = snd_pcm_new(card, "TM6000 Audio", 0, 0, 1, &pcm);
if (rc < 0)
- goto error;
+ goto error_chip;

pcm->info_flags = 0;
pcm->private_data = chip;
@@ -413,12 +413,15 @@ int tm6000_audio_init(struct tm6000_core *dev)

rc = snd_card_register(card);
if (rc < 0)
- goto error;
+ goto error_chip;

dprintk(1,"Registered audio driver for %s\n", card->longname);

return 0;

+error_chip:
+ kfree(chip);
+ dev->adev = NULL;
error:
snd_card_free(card);
return rc;
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: arch/microblaze: Removing dead CONTIGUOUS_PAGE_ALLOC config option
Next: [PATCH] staging: adis16255: fix sysfs leak