[PATCH tip/core/urgent 1/3] rcu: fix lockdep splat in wake_affine()
in [Kernel]
|
Prev: [PATCH tip/core/urgent 3/3] idr: fix RCU lockdep splat in idr_get_next()
Next: [PATCH tip/core/urgent 2/3] rcu: fix scope of wake_affine()'s new RCU read-side critical section
From: Paul E. McKenney on 15 Jun 2010 18:40 From: Daniel J Blueman <daniel.blueman(a)gmail.com> With 2.6.35-rc1 and your patch in the context below, we still see "include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!", so need this additional patch: Acquire read-side RCU lock around task_group() calls, addressing "include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!" warning. Signed-off-by: Daniel J Blueman <daniel.blueman(a)gmail.com> Signed-off-by: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com> --- kernel/sched_fair.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index eed35ed..ca56133 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -1240,6 +1240,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync) * effect of the currently running task from the load * of the current CPU: */ + rcu_read_lock(); if (sync) { tg = task_group(current); weight = current->se.load.weight; @@ -1249,6 +1250,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync) } tg = task_group(p); + rcu_read_unlock(); weight = p->se.load.weight; /* -- 1.7.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |