Prev: [PATCH] time: Cleanup warp_clock
Next: [PATCH 04/14] parisc: Convert parisc to use read/update_persistent_clock
From: Masami Hiramatsu on 3 Mar 2010 22:40
Fix stop_machine_text_poke() to issue smp_mb() before exiting waiting
loop, and use cpu_relax() for waiting.

Changes in v2:
- Don't use ACCESS_ONCE().

Signed-off-by: Masami Hiramatsu <mhiramat(a)redhat.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
Cc: Ingo Molnar <mingo(a)elte.hu>
Cc: Jason Baron <jbaron(a)redhat.com>
---

arch/x86/kernel/alternative.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 635e4f4..3a4bf35 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -597,8 +597,8 @@ static int __kprobes stop_machine_text_poke(void *data)
wrote_text = 1;
} else {
while (!wrote_text)
- smp_rmb();
- sync_core();
+ cpu_relax();
+ smp_mb(); /* Load wrote_text before following execution */
}

flush_icache_range((unsigned long)tpp->addr,


--
Masami Hiramatsu
e-mail: mhiramat(a)redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] time: Cleanup warp_clock
Next: [PATCH 04/14] parisc: Convert parisc to use read/update_persistent_clock