[PATCH v2] proc: Report file name on detected read_proc overflow
in [Kernel]
|
Prev: linux-next: Tree for April 1 (virtio_blk warning)
Next: [PATCHv5 4/4] tracing: graph output support for preemptirqsoff/preemptoff tracers
From: Jan Kiszka on 1 Apr 2010 12:20 This can help identifying the buggy read_proc handler. Signed-off-by: Jan Kiszka <jan.kiszka(a)siemens.com> --- fs/proc/generic.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) changes in v2: - keep "Apparent buffer overflow" in the same source code line - quote the file name with '' (Thanks, Frans!) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 08f4d71..ce14eca 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -132,7 +132,9 @@ __proc_file_read(struct file *file, char __user *buf, size_t nbytes, if (start == NULL) { if (n > PAGE_SIZE) { printk(KERN_ERR - "proc_file_read: Apparent buffer overflow!\n"); + "proc_file_read: Apparent buffer overflow" + " reading '%s'!\n", + file->f_path.dentry->d_name.name); n = PAGE_SIZE; } n -= *ppos; @@ -144,7 +146,9 @@ __proc_file_read(struct file *file, char __user *buf, size_t nbytes, } else if (start < page) { if (n > PAGE_SIZE) { printk(KERN_ERR - "proc_file_read: Apparent buffer overflow!\n"); + "proc_file_read: Apparent buffer overflow" + " reading '%s'!\n", + file->f_path.dentry->d_name.name); n = PAGE_SIZE; } if (n > count) { @@ -159,7 +163,9 @@ __proc_file_read(struct file *file, char __user *buf, size_t nbytes, unsigned long startoff = (unsigned long)(start - page); if (n > (PAGE_SIZE - startoff)) { printk(KERN_ERR - "proc_file_read: Apparent buffer overflow!\n"); + "proc_file_read: Apparent buffer overflow" + " reading '%s'!\n", + file->f_path.dentry->d_name.name); n = PAGE_SIZE - startoff; } if (n > count) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |