Prev: [PATCH v21 085/100] powerpc: provide APIs for validating and updating DABR
Next: [PATCH v21 006/100] eclone (6/11): Check invalid clone flags
From: Oren Laadan on 1 May 2010 10:40
From: Dan Smith <danms(a)us.ibm.com>

Make these helpers available to others.

Changes in v2:
- Avoid checking the groupinfo in ctx->realcred against the current in
may_setgid()

Signed-off-by: Dan Smith <danms(a)us.ibm.com>
Acked-by: Serge E. Hallyn <serue(a)us.ibm.com>
Tested-by: Serge E. Hallyn <serue(a)us.ibm.com>
---
include/linux/user.h | 9 +++++++++
kernel/user.c | 13 ++++++++++++-
2 files changed, 21 insertions(+), 1 deletions(-)

diff --git a/include/linux/user.h b/include/linux/user.h
index 68daf84..c231e9c 100644
--- a/include/linux/user.h
+++ b/include/linux/user.h
@@ -1 +1,10 @@
+#ifndef _LINUX_USER_H
+#define _LINUX_USER_H
+
#include <asm/user.h>
+#include <linux/sched.h>
+
+extern int may_setuid(struct user_namespace *ns, uid_t uid);
+extern int may_setgid(gid_t gid);
+
+#endif
diff --git a/kernel/user.c b/kernel/user.c
index 4d1fda6..c546fee 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -279,7 +279,7 @@ static int checkpoint_user(struct ckpt_ctx *ctx, void *ptr)
return do_checkpoint_user(ctx, (struct user_struct *) ptr);
}

-static int may_setuid(struct user_namespace *ns, uid_t uid)
+int may_setuid(struct user_namespace *ns, uid_t uid)
{
/*
* this next check will one day become
@@ -306,6 +306,17 @@ static int may_setuid(struct user_namespace *ns, uid_t uid)
return 0;
}

+int may_setgid(gid_t gid)
+{
+ if (capable(CAP_SETGID))
+ return 1;
+
+ if (in_egroup_p(gid))
+ return 1;
+
+ return 0;
+}
+
static struct user_struct *do_restore_user(struct ckpt_ctx *ctx)
{
struct user_struct *u;
--
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v21 085/100] powerpc: provide APIs for validating and updating DABR
Next: [PATCH v21 006/100] eclone (6/11): Check invalid clone flags