[PATCH v3 2/7] net: remove old tcp_optlen function
in [Kernel]
|
Prev: [PATCH v3 1/7] net: tcp_header_len_th and tcp_option_len_th
Next: net: reserve ports for applications using fixed port numbers
From: William Allen Simpson on 15 Feb 2010 07:30 The tcp_optlen() function returns a potential *negative* unsigned. In the only two existing files using the old tcp_optlen() function, clean up confusing and inconsistent mixing of both byte and word offsets, and other coding style issues. Document assumptions. Quoth David Miller: This is transmit, and the packets can only come from the Linux TCP stack, not some external entity. You're being way too anal here, and adding these checks to drivers would be just a lot of rediculious bloat. [sic] Therefore, there are *no* checks for bad TCP and IP header sizes, nor any semantic changes. The drivers should function exactly as existing. No response from testers in 17+ weeks. Requires: net: tcp_header_len_th and tcp_option_len_th Signed-off-by: William.Allen.Simpson(a)gmail.com CC: Michael Chan <mchan(a)broadcom.com> --- drivers/net/bnx2.c | 29 +++++++++++++----------- drivers/net/tg3.c | 60 +++++++++++++++++++++++--------------------------- include/linux/tcp.h | 5 ---- 3 files changed, 44 insertions(+), 50 deletions(-) |