Prev: proc_dointvec() and write
Next: ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mm
From: Will Drewry on 24 May 2010 10:50
On Mon, May 24, 2010 at 6:38 AM, Alasdair G Kergon <agk(a)redhat.com> wrote:
> I'll apply this, [snip]

Thanks!

On Mon, May 24, 2010 at 6:57 AM, Alasdair G Kergon <agk(a)redhat.com> wrote:
> On Wed, May 19, 2010 at 01:38:24PM -0500, Will Drewry wrote:
>> + � � char base_path[32]; �/* size from name_to_dev_t */
>
>> + � � /* stage the shorter path for name_to_dev_t. */
>> + � � strncpy(base_path, path, sizeof(base_path));
>
> I'm dropping that, and just passing path directly, so the strlen test
> will be used. �(There's a "name += 5" in there so 32 would ignore
> any longer standard names anyway.)

Sounds good. And nice catch on the truncation with 32 - in an
attempt to minimize the extra copying, I went a bit too far!

fwiw, the only reason for the copy was because |path| is a
const in the function but not when passed to name_to_dev_t.
I wasn't sure what the preferred practice was so I just duped
the data needed.

cheers!
will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Will Drewry on 24 May 2010 12:40
On Mon, May 24, 2010 at 10:07 AM, Alasdair G Kergon <agk(a)redhat.com> wrote:
> On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote:
>> fwiw, the only reason for the copy was because |path| is a
>> const in the function but not when passed to name_to_dev_t.
>> I wasn't sure what the preferred practice was so I just duped
>> the data needed.
>
> Well check that it is treated as 'const' and send a separate patch to
> the maintainer to add const, perhaps? �If it isn't const (why would
> that be?), then yes we'd need to copy it.

I'll cross-check the code again and send a patch out if it looks like
it is const-safe.

thanks,
will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: proc_dointvec() and write
Next: ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mm