[PATCH v4 2/7] net: remove old tcp_optlen function
in [Kernel]
|
Prev: [PATCH v3 1/7] net: tcp_header_len_th and tcp_option_len_th
Next: [PATCH v6 3/7] tcp: harmonize tcp_vx_rcv header length assumptions
From: William Allen Simpson on 11 Mar 2010 07:10 The tcp_optlen() function returns a potential *negative* unsigned. In the only two existing files using the old tcp_optlen() function, clean up confusing and inconsistent mixing of both byte and word offsets, and other coding style issues. Document assumptions. Quoth David Miller: This is transmit, and the packets can only come from the Linux TCP stack, not some external entity. You're being way too anal here, and adding these checks to drivers would be just a lot of rediculious bloat. [sic] Therefore, there are *no* checks for bad TCP and IP header sizes, nor any semantic changes. The drivers should function exactly as existing, although usage of int should ameliorate the issues. No response from testers in 21+ weeks. [removed comment references to commit log] Requires: net: tcp_header_len_th and tcp_option_len_th Signed-off-by: William.Allen.Simpson(a)gmail.com CC: Michael Chan <mchan(a)broadcom.com> --- drivers/net/bnx2.c | 29 +++++++++++++----------- drivers/net/tg3.c | 60 +++++++++++++++++++++++--------------------------- include/linux/tcp.h | 5 ---- 3 files changed, 44 insertions(+), 50 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |