Prev: x86: Make sure free_init_pages() free pages in boundary
Next: Staging: comedi frivers patches
From: Yinghai Lu on 26 Mar 2010 21:30

From: Ian Campbell <ian.campbell(a)citrix.com>

This avoids an infinite loop in free_early_partial().

Add a warning to free_early_partial to catch future problems.

-v5: put back start > end back into WARN_ONCE()
-v6: use one line for warning according to linus
-v7: more test by
-v8: remove the function name according to Johannes
WARN_ONCE will print that function name.

Signed-off-by: Ian Campbell <ian.campbell(a)citrix.com>
Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com>
Tested-by: Joel Becker <joel.becker(a)oracle.com>
Tested-by: Stanislaw Gruszka <sgruszka(a)redhat.com>
Acked-by: Johannes Weiner <hannes(a)cmpxchg.org>
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Ingo Molnar <mingo(a)elte.hu>
---
kernel/early_res.c | 6 ++++++
1 file changed, 6 insertions(+)

Index: linux-2.6/kernel/early_res.c
===================================================================
--- linux-2.6.orig/kernel/early_res.c
+++ linux-2.6/kernel/early_res.c
@@ -333,6 +333,12 @@ void __init free_early_partial(u64 start
struct early_res *r;
int i;

+ if (start == end)
+ return;
+
+ if (WARN_ONCE(start > end, " wrong range [%#llx, %#llx]\n", start, end))
+ return;
+
try_next:
i = find_overlapped_early(start, end);
if (i >= max_early_res)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: x86: Make sure free_init_pages() free pages in boundary
Next: Staging: comedi frivers patches