Prev: x86, acpi/irq: Handle isa irqs that are not identity mapped to gsi's.
Next: x86 acpi/irq: Fix harmless typo.
From: Eric W. Biederman on 5 May 2010 05:00 YH noticed that the function irq_to_gsi has an off by one error when translating high irq numbers to gsis. Today this bug is harmless because all of the callers restrict their input to the first 16 irqs so this bug does not matter, but we should fix it to avoid confusion and later. Signed-off-by: Eric W. Biederman <ebiederm(a)xmission.com> --- arch/x86/kernel/acpi/boot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index c9a5d3f..78222c8 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -132,7 +132,7 @@ static u32 irq_to_gsi(int irq) else if (irq <= gsi_end) gsi = irq; else if (irq <= (gsi_end + NR_IRQS_LEGACY)) - gsi = irq - gsi_end; + gsi = irq - (gsi_end + 1); else gsi = 0xffffffff; -- 1.6.5.2.143.g8cc62 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |