PM: Add suspend blocking work.
in [Kernel]
|
Prev: KVM MMU: allow more page become unsync at getting sp time
Next: [PATCH RESEND 1/2] Composite framework: Add suspended sysfs entry
From: Oleg Nesterov on 30 Apr 2010 14:30 On 04/28, Rafael J. Wysocki wrote: > > On Wednesday 28 April 2010, Tejun Heo wrote: > > On 04/28/2010 09:40 PM, Oleg Nesterov wrote: > > >> +int schedule_suspend_blocking_work(struct suspend_blocking_work *work) > > >> +{ > > >> ... > > >> + ret = schedule_work(&work->work); > > > > > > Off-topic. We should probably export keventd_wq to avoid the duplications > > > like this. > > > > Yeah, had about the same thought. cmwq exports it so I didn't suggest > > it at this point but then again we don't really know whether or when > > that series is going in > > As soon as there are no major objections. At least to my tree. > > > so it might be a good idea to make that change now. Hmm... > > I'd rather like a follow-up patch changing that, if poss. Confused. Rafael, do you mean you dislike this change now? I don't really care, this change is trivial. But to me it makes more sense to push the trivial/simple changes ahead. Unless they really complicate the maintainging of the pending cmwq changes. Hmm... Speaking about keventd_wq, I just noticed flush_delayed_work() needs the fix: --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -774,7 +774,7 @@ void flush_delayed_work(struct delayed_w { if (del_timer_sync(&dwork->timer)) { struct cpu_workqueue_struct *cwq; - cwq = wq_per_cpu(keventd_wq, get_cpu()); + cwq = wq_per_cpu(get_wq_data(&dwork->work)->wq, get_cpu()); __queue_work(cwq, &dwork->work); put_cpu(); } Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on 1 May 2010 02:20 On 05/01/2010 12:36 AM, Arve Hjønnevåg wrote: > Allow work to be queued that will block suspend while it is pending > or executing. To get the same functionality in the calling code often > requires a separate suspend_blocker for pending and executing work, or > additional state and locking. This implementation does add additional > state and locking, but this can be removed later if we add support for > suspend blocking work to the core workqueue code. > > Signed-off-by: Arve Hjønnevåg <arve(a)android.com> Reviewed-by: Tejun Heo <tj(a)kernel.org> Thank you. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 2 May 2010 03:10
On Fri 2010-04-30 15:36:59, Arve Hj??nnev??g wrote: > Allow work to be queued that will block suspend while it is pending > or executing. To get the same functionality in the calling code often > requires a separate suspend_blocker for pending and executing work, or > additional state and locking. This implementation does add additional > state and locking, but this can be removed later if we add support for > suspend blocking work to the core workqueue code. > > Signed-off-by: Arve Hj??nnev??g <arve(a)android.com> Looks ok. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |