From: reinette chatre on
Hi Stanislaw,

On Tue, 2010-02-09 at 08:52 -0800, Stanislaw Gruszka wrote:
>
> > > [250420.677168] Pid: 11584, comm: ip Not tainted 2.6.32.3 #5
> > > [250420.677173] Call Trace:
> > > [250420.677190] [<c10a53f8>] ? __alloc_pages_nodemask+0x518/0x5f0
> > > [250420.677204] [<c1007c20>] ? dma_generic_alloc_coherent+0x0/0x100
> > > [250420.677214] [<c1007c92>] ? dma_generic_alloc_coherent+0x72/0x100
> > > [250420.677224] [<c1007c20>] ? dma_generic_alloc_coherent+0x0/0x100
> > > [250420.677241] [<fca1c9d5>] ? iwl_tx_queue_init+0x285/0x380 [iwlcore]
>
> That is at initialization time. To avoid atomic allocation we can just
> use dma_alloc_coherent instead of pci_alloc_consistent. I'm going to
> prepare a patch.

I do not understand your goal here ... as seen in this trace
pci_alloc_consistent itself already calls dma_alloc_coherent right away.

Reinette


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stanislaw Gruszka on
Hi

On Tue, Feb 09, 2010 at 09:04:52AM -0800, reinette chatre wrote:
> I do not understand your goal here ... as seen in this trace
> pci_alloc_consistent itself already calls dma_alloc_coherent right away.

We can call dma_alloc_coherent with GFP_KERNEL, pci_alloc_consistent is
more or less equal to dma_alloc_coherent with GFP_ATOMIC flag.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/