Panic in reserve_memtype()
in [Kernel]
|
From: Jack Steiner on 1 Mar 2010 10:20 On Wed, Feb 24, 2010 at 04:05:18PM -0600, Jack Steiner wrote: > > > > I guess I found an obvious problem in the code. Can you check whether the > > below patch resolves the panic you are seeing. > > > > Thanks, > > Venki > > > Works great!! Thanks... Venki Were you planning to push this fix upstream? Both the x86 & linux-next tree currently fail to boot on EFI-enabled systems because of this bug. Thanks... --- jack > > > > > > > > new->type should only change when there is a valid ret_type. Otherwise > > requested type and return type should be same. > > > > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi(a)intel.com> > > --- > > arch/x86/mm/pat_rbtree.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c > > index e4cd229..58b6de1 100644 > > --- a/arch/x86/mm/pat_rbtree.c > > +++ b/arch/x86/mm/pat_rbtree.c > > @@ -223,7 +223,9 @@ int rbt_memtype_check_insert(struct memtype *new, unsigned long *ret_type) > > new->type, ret_type); > > > > if (!err) { > > - new->type = *ret_type; > > + if (ret_type) > > + new->type = *ret_type; > > + > > memtype_rb_insert(&memtype_rbroot, new); > > } > > return err; > > -- > > 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pallipadi, Venkatesh on 1 Mar 2010 13:00 Adding Peter. Can you push this patch along. Thanks Venki On Mon, 2010-03-01 at 07:11 -0800, Jack Steiner wrote: > On Wed, Feb 24, 2010 at 04:05:18PM -0600, Jack Steiner wrote: > > > > > > > I guess I found an obvious problem in the code. Can you check whether the > > > below patch resolves the panic you are seeing. > > > > > > Thanks, > > > Venki > > > > > > Works great!! Thanks... > > > Venki > > Were you planning to push this fix upstream? Both the x86 & linux-next tree > currently fail to boot on EFI-enabled systems because of this bug. > > Thanks... > > > --- jack > > > > > > > > > > > > > new->type should only change when there is a valid ret_type. Otherwise > > > requested type and return type should be same. > > > > > > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi(a)intel.com> > > > --- > > > arch/x86/mm/pat_rbtree.c | 4 +++- > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c > > > index e4cd229..58b6de1 100644 > > > --- a/arch/x86/mm/pat_rbtree.c > > > +++ b/arch/x86/mm/pat_rbtree.c > > > @@ -223,7 +223,9 @@ int rbt_memtype_check_insert(struct memtype *new, unsigned long *ret_type) > > > new->type, ret_type); > > > > > > if (!err) { > > > - new->type = *ret_type; > > > + if (ret_type) > > > + new->type = *ret_type; > > > + > > > memtype_rb_insert(&memtype_rbroot, new); > > > } > > > return err; > > > -- > > > 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Pages: 1 2 Prev: RapidIO: Add IDT CPS/TSI switches Next: [PATCH 2/3] workqueues: microoptimize set_wq_data() |