Prev: Per-column collation, proof of concept
Next: [HACKERS] CommitFest 2010-07 now in progress
From: Euler Taveira de Oliveira on 23 Jul 2010 09:38
David Christensen escreveu:
> Like I said in the original submission, I found it helpful for the programmatic configuration of a number of simultaneous node, but if it's not generally useful to the community at large, I'll understand if it's punted.
>
I'm afraid it is the only use case for this new option. If it is, it doesn't
deserve a new option. We can live with echo + initdb for those cases.


--
Euler Taveira de Oliveira
http://www.timbira.com/

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: "Kevin Grittner" on 23 Jul 2010 09:51
David Christensen <david(a)endpoint.com> wrote:

> At this point, I have no real preference for this patch; it is
> just as easy to echo line >> datadir/postgresql.conf, so perhaps
> that makes this patch somewhat pointless.

On reflection, I'm inclined to agree.

> I suppose there's a shaky argument to be made for Windows
> compatibility, but I'm sure there's also an equivalent
> functionality to be found in the windows shell.

The Windows command shell supports the echo command and >> to
append.

> Like I said in the original submission, I found it helpful for
> the programmatic configuration of a number of simultaneous node,
> but if it's not generally useful to the community at large, I'll
> understand if it's punted.

Unless someone can show a significant benefit beyond >> appends,
I'll do that in a couple days.

-Kevin

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on 23 Jul 2010 07:36
2010/7/23 KaiGai Kohei <kaigai(a)ak.jp.nec.com>:
> Sorry for the confusion.
>
> What I wanted to say is the patch itself is fine but we need to make consensus
> before the detailed code reviewing.

I guess we probably need some more people to express an opinion, then.
Do you have one?

I'm not sure I do, yet. I'd like to hear the patch author's response
to Itagaki Takahiro's question upthread: "Why don't you use just "echo
'options' >> $PGDATA/postgresql.conf" ? Could you explain where the
-C options is better than initdb + echo?"

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2 3
Prev: Per-column collation, proof of concept
Next: [HACKERS] CommitFest 2010-07 now in progress