Patch for PKST timezone
in [PgSql]
|
From: Joachim Wieland on 11 May 2010 17:38 On Tue, May 11, 2010 at 10:45 AM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > I don't think we want to include all timezone names in the default > config, timezone abbreviations aren't always unique for example. But we > should include PKST because we already include PKT; it would be nasty > for an application to work during winter, and stop working when the > daylight saving time begins. I agree with everything Heikki says. As the original author of the timezone files I guess that I am to blame for not having included PKST in the first place. However I have the excuse that it was like that already back when the timezone information was still hardcoded, we had "pkt" but not "pkst": http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?rev=1.168;content-type=text%2Fx-cvsweb-markup Good we have found that inconsistency now, so let's add PKST. I also agree with not adding more than necessary to the default config set. Given that so few people complain about it we seem to have a good working default set already. Joachim -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 11 May 2010 18:39
Joachim Wieland <joe(a)mcknight.de> writes: > Good we have found that inconsistency now, so let's add PKST. OK, done. BTW, I notice that PKT was labeled "(not in zic)", which is not the case, per this discussion. I seem to recall having noticed some others that seemed to be mislabeled the same way. What process did you use to compare this list to the zic files, and do we need to revisit it? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |