Prev: bitops: compile time optimization for hweight_long(CONSTANT)
Next: [RFC] Dell activity led WMI driver
From: Steve Kemp on 1 Feb 2010 17:00
arch/m32r/kernel/smp.c contains the following code:

--
preempt_disable();
cpu_id = smp_processor_id();
mmc = &mm->context[cpu_id];
cpu_mask = mm->cpu_vm_mask;
cpu_clear(cpu_id, cpu_mask);

#iffdef DEBUG_SMP
if (!mm)
BUG();
#endif
--

mm might be NULL, but this would only be detected after it
has been dereferenced, and only then if DEBUG_SMP is defined.

I'd suggest changing to read something like this:

--
if ( !mm )
BUG();

preempt_disable();
--

Steve
--
http://www.steve.org.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: bitops: compile time optimization for hweight_long(CONSTANT)
Next: [RFC] Dell activity led WMI driver