From: Fujii Masao on 6 Apr 2010 03:07 On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > To follow up on the discussion here: > > http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php > > It seems like a big oversight that there's no way to insert quotes in > strings in recovery.conf. In the long run, the parsing should be done > the same way as postgresql.conf, or the two files be merged altogether, > but right now I think we should just add support for escaping quotes. I > propose two quotes '' to mean a quote mark in the string, like in > strings in SQL queries. Agreed. This would be useful for users to specify the application_name containing a space in the primary_conninfo, for example. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 6 Apr 2010 07:45 On Tue, 2010-04-06 at 16:07 +0900, Fujii Masao wrote: > On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas > <heikki.linnakangas(a)enterprisedb.com> wrote: > > To follow up on the discussion here: > > > > http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php > > > > It seems like a big oversight that there's no way to insert quotes in > > strings in recovery.conf. In the long run, the parsing should be done > > the same way as postgresql.conf, or the two files be merged altogether, > > but right now I think we should just add support for escaping quotes. I > > propose two quotes '' to mean a quote mark in the string, like in > > strings in SQL queries. > > Agreed. This would be useful for users to specify the application_name > containing a space in the primary_conninfo, for example. +1 -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Heikki Linnakangas on 6 Apr 2010 12:48 Simon Riggs wrote: > On Tue, 2010-04-06 at 16:07 +0900, Fujii Masao wrote: >> On Tue, Apr 6, 2010 at 3:47 PM, Heikki Linnakangas >> <heikki.linnakangas(a)enterprisedb.com> wrote: >>> To follow up on the discussion here: >>> >>> http://archives.postgresql.org/pgsql-docs/2010-02/msg00039.php >>> >>> It seems like a big oversight that there's no way to insert quotes in >>> strings in recovery.conf. In the long run, the parsing should be done >>> the same way as postgresql.conf, or the two files be merged altogether, >>> but right now I think we should just add support for escaping quotes. I >>> propose two quotes '' to mean a quote mark in the string, like in >>> strings in SQL queries. >> Agreed. This would be useful for users to specify the application_name >> containing a space in the primary_conninfo, for example. > > +1 Ok, here's what I came up with. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
From: Fujii Masao on 6 Apr 2010 22:38 On Wed, Apr 7, 2010 at 1:48 AM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > Ok, here's what I came up with. Looks OK to me. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Heikki Linnakangas on 7 Apr 2010 06:59 Fujii Masao wrote: > On Wed, Apr 7, 2010 at 1:48 AM, Heikki Linnakangas > <heikki.linnakangas(a)enterprisedb.com> wrote: >> Ok, here's what I came up with. > > Looks OK to me. Committed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Pages: 1 Prev: [HACKERS] Quoting in recovery.conf Next: [HACKERS] Question about WAL and XID |