Prev: [PATCH, fix 1/2] Add the platform data include for the Xilinx XPS IIC Bus Interface
Next: should new kfifo implementation really be exporting that much?
From: Florian Fainelli on 14 Mar 2010 08:50 Samuel, Any comments on this? Thanks. Le jeudi 11 mars 2010 09:42:03, Florian Fainelli a écrit : > Hi Wim, Samuel, Ingo, > > Here are 4 patches relative to adding support for the RDC321x southbridge. > This southbridge is present on all x86-based RDC321x System-on-a-Chip and > provides access to GPIOs and Wathchdog. The watchdog driver is already > merged. > > Samuel, this is rebased on top of your mfd-2.6 master branch after commit > 522dba7 and I think the 4 patches should go via your tree to make sure the > merge is consistent. > > Thank you. > > Florian Fainelli (4): > x86: remove rdc321x_defs.h > MFD: add support for the RDC321x southbridge > GPIO: add support for RDC321x GPIO controller > WATCHDOG: convert rdc321x_wdt to use southbridge accessors > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Wim Van Sebroeck on 17 Mar 2010 10:20 Hi Florian, > Here are 4 patches relative to adding support for the RDC321x southbridge. > This southbridge is present on all x86-based RDC321x System-on-a-Chip and > provides access to GPIOs and Wathchdog. The watchdog driver is already merged. > > Samuel, this is rebased on top of your mfd-2.6 master branch after commit > 522dba7 and I think the 4 patches should go via your tree to make sure the > merge is consistent. > > Thank you. > > Florian Fainelli (4): > x86: remove rdc321x_defs.h > MFD: add support for the RDC321x southbridge > GPIO: add support for RDC321x GPIO controller > WATCHDOG: convert rdc321x_wdt to use southbridge accessors Watchdog part is OK for me. So Acked-by me can be added. Personally I don't like the fact that you remove the rdc321x_defs.h file as the first patch. If someone bisects the kernel, he will get a broken driver between the first and the fourth patch. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 25 Mar 2010 07:30 Hi Florian, On Sun, Mar 21, 2010 at 01:06:01AM +0100, Florian Fainelli wrote: > Hi Samuel, Andrew, > > This is the third round of the RDC321x southbridge and GPIO support, this > version should hopefully address all of your comments. All 4 (I took v2 for the watchdog) patches applies, thanks. Cheers, Samuel. > Thanks! > > Florian Fainelli (4): > MFD: add support for the RDC321x southbridge > GPIO: add support for RDC321x GPIO controller > WATCHDOG: convert rdc321x_wdt to use southbridge pci device > x86: remove rdc321x_defs.h -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 25 Mar 2010 07:40 On Thu, Mar 25, 2010 at 12:27:27PM +0100, Samuel Ortiz wrote: > Hi Florian, > > On Sun, Mar 21, 2010 at 01:06:01AM +0100, Florian Fainelli wrote: > > Hi Samuel, Andrew, > > > > This is the third round of the RDC321x southbridge and GPIO support, this > > version should hopefully address all of your comments. > All 4 (I took v2 for the watchdog) patches applies, thanks. Nevermind, I had to take v3 version for the watchdog, although I couldnt find it in my inbox. Cheers, Samuel. > > Cheers, > Samuel. > > > > Thanks! > > > > Florian Fainelli (4): > > MFD: add support for the RDC321x southbridge > > GPIO: add support for RDC321x GPIO controller > > WATCHDOG: convert rdc321x_wdt to use southbridge pci device > > x86: remove rdc321x_defs.h > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Florian Fainelli on 25 Mar 2010 08:10
On Thursday 25 March 2010 12:35:13 Samuel Ortiz wrote: > On Thu, Mar 25, 2010 at 12:27:27PM +0100, Samuel Ortiz wrote: > > Hi Florian, > > > > On Sun, Mar 21, 2010 at 01:06:01AM +0100, Florian Fainelli wrote: > > > Hi Samuel, Andrew, > > > > > > This is the third round of the RDC321x southbridge and GPIO support, > > > this version should hopefully address all of your comments. > > > > All 4 (I took v2 for the watchdog) patches applies, thanks. > > Nevermind, I had to take v3 version for the watchdog, although I couldnt > find it in my inbox. Thank you! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |