Prev: rwsem: test for no active locks in __rwsem_do_wake undo code
Next: rwsem: use single atomic update for sem count when waking up readers.
From: Catalin Marinas on 12 May 2010 07:10
On Tue, 2010-05-11 at 11:33 +0100, Kirill A. Shutemov wrote:
> Between "clean D line..." and "invalidate I line" operations in
> v7_coherent_user_range(), the memory page may get swapped out.
> And the fault on "invalidate I line" could not be properly handled
> causing the oops.
>
> In ARMv6 "external abort on linefetch" replaced by "instruction cache
> maintenance fault". Let's handle it as translation fault. It fixes the
> issue.
>
> I'm not sure if it's reasonable to check arch version in run-time.
> Let's do it in compile time for now.
>
> Signed-off-by: Siarhei Siamashka <siarhei.siamashka(a)nokia.com>
> Signed-off-by: Kirill A. Shutemov <kirill(a)shutemov.name>

FWIW:

Reviewed-by: Catalin Marinas <catalin.marinas(a)arm.com>

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Catalin Marinas on 14 May 2010 09:40
On Tue, 2010-05-11 at 11:33 +0100, Kirill A. Shutemov wrote:
> diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> index 9d40c34..7f193ea 100644
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -463,7 +463,12 @@ static struct fsr_info {
> { do_bad, SIGILL, BUS_ADRALN, "alignment exception" },
> { do_bad, SIGKILL, 0, "terminal exception" },
> { do_bad, SIGILL, BUS_ADRALN, "alignment exception" },
> +/* Do we need runtime check ? */
> +#if __LINUX_ARM_ARCH__ < 6
> { do_bad, SIGBUS, 0, "external abort on linefetch" },
> +#else
> + { do_translation_fault, SIGSEGV, SEGV_MAPPER, "I-cache maintenance
> fault" },
> +#endif

Apart from line wrapping, it should be SEGV_MAPERR above.

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: rwsem: test for no active locks in __rwsem_do_wake undo code
Next: rwsem: use single atomic update for sem count when waking up readers.