Prev: [tip:x86/urgent] x86: SGI UV: Fix mapping of MMIO registers
Next: [PATCH 6/8] hwpoison: prevent /dev/kmem from accessing hwpoison pages
From: Uwe Kleine-König on 13 Jan 2010 06:10
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
Cc: David Vrabel <dvrabel(a)arcom.com>
Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
Cc: Rafael J. Wysocki <rjw(a)sisk.pl>
Cc: linux-pcmcia(a)lists.infradead.org
---
drivers/pcmcia/bfin_cf_pcmcia.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/bfin_cf_pcmcia.c b/drivers/pcmcia/bfin_cf_pcmcia.c
index 300b368..2482ce7 100644
--- a/drivers/pcmcia/bfin_cf_pcmcia.c
+++ b/drivers/pcmcia/bfin_cf_pcmcia.c
@@ -205,7 +205,7 @@ static int __devinit bfin_cf_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "Blackfin CompactFlash/PCMCIA Socket Driver\n");

irq = platform_get_irq(pdev, 0);
- if (!irq)
+ if (irq <= 0)
return -EINVAL;

cd_pfx = platform_get_irq(pdev, 1); /*Card Detect GPIO PIN */
--
1.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [tip:x86/urgent] x86: SGI UV: Fix mapping of MMIO registers
Next: [PATCH 6/8] hwpoison: prevent /dev/kmem from accessing hwpoison pages