Prev: Linux 2.6.34-rc4
Next: [PATCH] Kconfig: Make config Filter access to /dev/mem default y
From: Mike Christie on 12 Apr 2010 22:40
On 04/12/2010 09:21 PM, Konrad Rzeszutek Wilk wrote:
>> + * Helper routiners to check to determine if the entry is valid
>> + * in the proper iBFT structure.
>> + */
>> +static mode_t ibft_check_nic_for(void *data, int type)
>> +{
>> + struct ibft_kobject *entry = data;
>> + struct ibft_nic *nic = entry->nic;
>> + mode_t rc = 0;
>> +
>> + switch (type) {
>> + case ISCSI_BOOT_ETH_INDEX:
>> + case ISCSI_BOOT_ETH_FLAGS:
>> + rc = 1;
>
> Did you mean for that value?
>> + break;
>> + case ISCSI_BOOT_ETH_IP_ADDR:
>> + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
>> + rc = S_IRUGO;
>> + break;
>> + case ISCSI_BOOT_ETH_SUBNET_MASK:
>> + if (nic->subnet_mask_prefix)
>> + rc = S_IRUGO;
>> + break;
>> + case ISCSI_BOOT_ETH_ORIGIN:
>> + rc = 1;
>
> and this one as well?

I did not. They should be S_IRUGO. Do you want me to resubmit the
patches or are you just going to edit those two lines if you merge them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Peter Jones on 13 Apr 2010 11:10
On 04/12/2010 10:36 PM, Konrad Rzeszutek Wilk wrote:
> On Monday 12 April 2010 22:32:33 Mike Christie wrote:
>> On 04/12/2010 09:21 PM, Konrad Rzeszutek Wilk wrote:
>>>> + * Helper routiners to check to determine if the entry is valid
>>>> + * in the proper iBFT structure.
>>>> + */
>>>> +static mode_t ibft_check_nic_for(void *data, int type)
>>>> +{
>>>> + struct ibft_kobject *entry = data;
>>>> + struct ibft_nic *nic = entry->nic;
>>>> + mode_t rc = 0;
>>>> +
>>>> + switch (type) {
>>>> + case ISCSI_BOOT_ETH_INDEX:
>>>> + case ISCSI_BOOT_ETH_FLAGS:
>>>> + rc = 1;
>>>
>>> Did you mean for that value?
>>>
>>>> + break;
>>>> + case ISCSI_BOOT_ETH_IP_ADDR:
>>>> + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
>>>> + rc = S_IRUGO;
>>>> + break;
>>>> + case ISCSI_BOOT_ETH_SUBNET_MASK:
>>>> + if (nic->subnet_mask_prefix)
>>>> + rc = S_IRUGO;
>>>> + break;
>>>> + case ISCSI_BOOT_ETH_ORIGIN:
>>>> + rc = 1;
>>>
>>> and this one as well?
>>
>> I did not. They should be S_IRUGO. Do you want me to resubmit the
>> patches or are you just going to edit those two lines if you merge them?
>
> No need to resend them (unless Peter eyes found something I missed).

Nope, that's all I see.

--
Peter

Sanity's just a one trick pony anyway. You only get one trick -- rational
thinking -- but when you're good and crazy, the sky's the limit!
-- The Tick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Linux 2.6.34-rc4
Next: [PATCH] Kconfig: Make config Filter access to /dev/mem default y