ROLLBACK TO SAVEPOINT
in [PgSql]
|
From: Florian Pflug on 26 May 2010 20:25 On May 27, 2010, at 0:58 , Heikki Linnakangas wrote: > On 26/05/10 02:00, Sam Vilain wrote: >> Florian Pflug wrote: >>> On May 25, 2010, at 12:18 , Heikki Linnakangas wrote: >>>> Releasing the newer savepoint will cause the older one to again become accessible, as the doc says, but rolling back to a savepoint does not implicitly release it. You'll have to use RELEASE SAVEPOINT for that. >>> >>> Ah, now I get it. Thanks. >>> >>> Would changing "Releasing the newer savepoint will cause ... " to "Explicitly releasing the newer savepoint" or maybe even "Explicitly releasing the newer savepoint with RELEASE SAVEPOINT will cause ..." make things clearer? >> >> Yes, probably - your misreading matches my misreading of it :-) > > +1. Patch that changes the wording to "Explicitly releasing the newer savepoint with RELEASE SAVEPOINT will cause ..." is attached. Unfortunately, this patch is untested. I couldn't get openjade + DocBook to work on OSX for some reason :-( best regards, Florian Pflug
From: Robert Haas on 26 May 2010 20:52 On Wed, May 26, 2010 at 8:25 PM, Florian Pflug <fgp(a)phlo.org> wrote: > Unfortunately, this patch is untested. I couldn't get openjade + DocBook to work on OSX for some reason :-( That is a truly awful nightmare. Dave Page dug up some old instructions which got me through it - I'm guessing he doesn't mind my posting them, but let me double-check with him first. Actually, I think we should incorporate them into our docs. It's beyond me how anyone ever got this to work, even once. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Mark Kirkwood on 26 May 2010 22:08 On 27/05/10 12:25, Florian Pflug wrote: > > > Patch that changes the wording to "Explicitly releasing the newer savepoint with RELEASE SAVEPOINT will cause ..." is attached. > > Unfortunately, this patch is untested. I couldn't get openjade + DocBook to work on OSX for some reason :-( > > FWIW docs with this patch seem to build ok for me on Ubuntu Lucid 64 bit. regards Mark -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Heikki Linnakangas on 27 May 2010 02:26 On 27/05/10 03:25, Florian Pflug wrote: > On May 27, 2010, at 0:58 , Heikki Linnakangas wrote: >> On 26/05/10 02:00, Sam Vilain wrote: >>> Florian Pflug wrote: >>>> On May 25, 2010, at 12:18 , Heikki Linnakangas wrote: >>>>> Releasing the newer savepoint will cause the older one to again become accessible, as the doc says, but rolling back to a savepoint does not implicitly release it. You'll have to use RELEASE SAVEPOINT for that. >>>> >>>> Ah, now I get it. Thanks. >>>> >>>> Would changing "Releasing the newer savepoint will cause ... " to "Explicitly releasing the newer savepoint" or maybe even "Explicitly releasing the newer savepoint with RELEASE SAVEPOINT will cause ..." make things clearer? >>> >>> Yes, probably - your misreading matches my misreading of it :-) >> >> +1. > > Patch that changes the wording to "Explicitly releasing the newer savepoint with RELEASE SAVEPOINT will cause ..." is attached. Thanks, committed. I left out the "Explicitly", though, because as Sam pointed out the newer savepoint can also be implicitly released by rolling back to an earlier savepoint. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
First
|
Prev
|
Pages: 1 2 Prev: [HACKERS] ROLLBACK TO SAVEPOINT Next: [HACKERS] Hot Standby performance and deadlocking |