Prev: [HACKERS] how to use advanced gist options
Next: [HACKERS] WIP: simple allocator
From: Greg Smith on 23 Mar 2010 00:00
Takahiro Itagaki wrote:
> Greg Smith <greg(a)2ndquadrant.com> wrote:
>
>
>> Attached is an updated version that I think is ready to commit. Only
>> changes are docs--I rewrote those to improve the wording some.
>>
>
> Thanks for the correction. Applied.
>

By the way: the pgbench.sgml that you committed looks like it passed
through a system that added a CR to every line in it. Probably not the
way you intended to commit that.

So far I've done over 40 hours of pgbench runtime worth of testing (>500
runs) using the patched version without any issues, the code itself
continues to act fine.

--
Greg Smith 2ndQuadrant US Baltimore, MD
PostgreSQL Training, Services and Support
greg(a)2ndQuadrant.com www.2ndQuadrant.us


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Takahiro Itagaki on 23 Mar 2010 00:10

Greg Smith <greg(a)2ndquadrant.com> wrote:

> By the way: the pgbench.sgml that you committed looks like it passed
> through a system that added a CR to every line in it. Probably not the
> way you intended to commit that.

Oops, fixed. Thanks.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Magnus Hagander on 23 Mar 2010 04:37
On Tue, Mar 23, 2010 at 05:10, Takahiro Itagaki
<itagaki.takahiro(a)oss.ntt.co.jp> wrote:
>
> Greg Smith <greg(a)2ndquadrant.com> wrote:
>
>> By the way: the pgbench.sgml that you committed looks like it passed
>> through a system that added a CR to every line in it.  Probably not the
>> way you intended to commit that.
>
> Oops, fixed. Thanks.

My guess is that this happened because you committed from Windows?

I learned the hard way that this is a bad idea. (Luckily I learned it
on other CVS projects, before I started committing to PostgreSQL).
There are settings to make it not do that, but they are not reliable.
I'd strongly suggest that you always just do a cvs diff on windows and
then use a staging machine running linux or bsd or something to apply
it through. And then you *always* run those patches through something
like "fromdos". It's a bunch of extra steps, but it's really the only
way to do it reliably.

If that's not at all what happened, then well, it's still good advice
I think, even if it doesn't apply :-)


--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2 3
Prev: [HACKERS] how to use advanced gist options
Next: [HACKERS] WIP: simple allocator