Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2
in [Kernel]
|
From: Tino Keitel on 15 Jan 2010 04:20 Hi, wake on LAN doesn't work with 2.6.33-rc4-git2 on the following hardware: 01:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. 88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 22) It worked with 2.6.32. In my suspend script, I enable WoL using ethtool: ethtool -s eth0 wol g in dmesg, I get these messages at suspend: sky2 eth0: disabling interface sky2 0000:01:00.0: PME# enabled sky2 0000:01:00.0: wake-up capability enabled by ACPI and at resume: sky2 0000:01:00.0: wake-up capability disabled by ACPI sky2 0000:01:00.0: PME# disabled Regards, Tino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on 15 Jan 2010 17:30 On Friday 15 January 2010, Stephen Hemminger wrote: > On Fri, 15 Jan 2010 10:10:53 +0100 > Tino Keitel <tino.keitel(a)tikei.de> wrote: > > > Hi, > > > > wake on LAN doesn't work with 2.6.33-rc4-git2 on the following > > hardware: > > > > 01:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. > > 88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 22) > > > > It worked with 2.6.32. In my suspend script, I enable WoL using > > ethtool: > > > > ethtool -s eth0 wol g > > > > in dmesg, I get these messages at suspend: > > > > sky2 eth0: disabling interface > > sky2 0000:01:00.0: PME# enabled > > sky2 0000:01:00.0: wake-up capability enabled by ACPI > > > > and at resume: > > > > sky2 0000:01:00.0: wake-up capability disabled by ACPI > > sky2 0000:01:00.0: PME# disabled > > > > Regards, > > Tino > > This has already been reported. > > Rafael has been doing the generic PM stuff. > Look for thread, > [Bug 14730] sky2 won't work after suspend/resume cycle This has been fixed already and the bug appears to be different. No idea what it is at the moment. Tino, please check if reverting commit dc1a94ae1749d14c55f8b54e9d92bd89df82d51a helps, although the messages indicate that the generic PCI-side does its job. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on 17 Jan 2010 19:40 On Monday 18 January 2010, Tino Keitel wrote: > On Fri, Jan 15, 2010 at 23:23:37 +0100, Rafael J. Wysocki wrote: > > On Friday 15 January 2010, Stephen Hemminger wrote: > > [...] > > > > This has already been reported. > > > > > > Rafael has been doing the generic PM stuff. > > > Look for thread, > > > [Bug 14730] sky2 won't work after suspend/resume cycle > > > > This has been fixed already and the bug appears to be different. > > Yes, sounds different. The interface works after a resume. My issue is > that the computer just won't resume at all using wake on LAN. > > > > > No idea what it is at the moment. > > > > Tino, please check if reverting commit > > dc1a94ae1749d14c55f8b54e9d92bd89df82d51a helps, although the messages > > indicate that the generic PCI-side does its job. > > No luck with the commit reverted, WoL still doesn't work. Well, this commit is the only PCI core change affecting WoL after 2.6.32 IIRC. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mike McCormack on 18 Jan 2010 07:10 Tino Keitel wrote: > Hi, > > reverting this commit fixes WoL for me: > > commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75 Hi Tino, Does this fix WoL also? Compile tested only... thanks, Mike Subject: [PATCH] sky2: Disable writes to PCI space before suspend Tino Keitel found that reverting 166a0fd4c fixes WoL for him. This suggests that PCI config should not be writable when suspended. Signed-off-by: Mike McCormack <mikem(a)ring3k.org> --- drivers/net/sky2.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index 4c06020..b54edec 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c @@ -4789,6 +4789,9 @@ static int sky2_suspend(struct pci_dev *pdev, pm_message_t state) sky2_power_aux(hw); rtnl_unlock(); + /* disable writes to PCI config again */ + sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF); + pci_save_state(pdev); pci_enable_wake(pdev, pci_choose_state(pdev, state), wol); pci_set_power_state(pdev, pci_choose_state(pdev, state)); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on 18 Jan 2010 16:40 On Monday 18 January 2010, Tino Keitel wrote: > Hi, > > reverting this commit fixes WoL for me: > > commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75 > Author: stephen hemminger <shemminger(a)vyatta.com> > Date: Mon Dec 14 08:50:12 2009 +0000 > > sky2: leave PCI config space writeable > > Since power management is done by PCI subsystem as well as driver, > don't toggle the bit that disables PCI register writes. > > Signed-off-by: Stephen Hemminger <shemminger(a)vyatta.com> > Acked-by: Rafael J. Wysocki <rjw(a)sisk.pl> > Signed-off-by: David S. Miller <davem(a)davemloft.net> Hmm, this is kind of interesting. Perhaps we clear the WoL setting somewhere we shouldn't, but the "disable PCI register writes" bit prevents this from actually happening? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Next
|
Last
Pages: 1 2 Prev: net/core/sock.c: quiet sparse noise Next: MAINTAINERS: transfer maintainership of I/OAT |