From: Simon Riggs on
On Tue, 2010-04-06 at 10:09 +0300, Heikki Linnakangas wrote:

> > * Walsender and dblink are not interruptible on win32. - related thread
>
> I'd actually be happy to just leave it for 9.0, but it seems like
> consensus has been reached on how to fix it, and Fujii is working on a
> patch, so let's follow that through.

That one is a must, for me.

I would put relaying easily above any of the other stuff. That is a
truly useful feature that we are very close to being able to have in
this release. Adding things like quotes is not moving us forwards in any
important sense.

--
Simon Riggs www.2ndQuadrant.com


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs <simon(a)2ndquadrant.com> wrote:
> On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote:
>
>> >>>>     * Redefine smart shutdown in standby mode?
>> >>> Drop. Too big a change at this point.
>> >>
>> >> We have a working patch for this - I want to commit it.  I don't think
>> >> it's a big change, and the current behavior is extremely pathological.
>> >
>> > Oh, ok. I didn't look at the latest patch, if it looks good to you, fine
>> > with me.
>>
>> I'll commit it tonight.
>
> I don't see this on hackers. Have you posted it? I'd like to see what
> you do before it gets committed. Thanks.

It's the same patch Fujii Masao posted previously, for which I
previously said I would fix up the comments and docs and commit. But
here is the adjusted version, which is hopefully more clear about what
we're doing at why we're doing it.

....Robert
From: Simon Riggs on
On Wed, 2010-04-07 at 07:40 -0400, Robert Haas wrote:
> On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs <simon(a)2ndquadrant.com> wrote:
> > On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote:
> >
> >> >>>> * Redefine smart shutdown in standby mode?
> >> >>> Drop. Too big a change at this point.
> >> >>
> >> >> We have a working patch for this - I want to commit it. I don't think
> >> >> it's a big change, and the current behavior is extremely pathological.
> >> >
> >> > Oh, ok. I didn't look at the latest patch, if it looks good to you, fine
> >> > with me.
> >>
> >> I'll commit it tonight.
> >
> > I don't see this on hackers. Have you posted it? I'd like to see what
> > you do before it gets committed. Thanks.
>
> It's the same patch Fujii Masao posted previously, for which I
> previously said I would fix up the comments and docs and commit. But
> here is the adjusted version, which is hopefully more clear about what
> we're doing at why we're doing it.

OK, that looks a lot less risky than I had understood from discussions.
The main thing for me is it doesn't interfere with Startup or
WalReceiver, so assuming it works I've got no objections. Thanks for
chasing this down, good addition.

--
Simon Riggs www.2ndQuadrant.com


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Wed, Apr 7, 2010 at 8:17 AM, Simon Riggs <simon(a)2ndquadrant.com> wrote:
> OK, that looks a lot less risky than I had understood from discussions.
> The main thing for me is it doesn't interfere with Startup or
> WalReceiver, so assuming it works I've got no objections. Thanks for
> chasing this down, good addition.

Thanks. Committed.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Tue, Apr 6, 2010 at 4:09 PM, Simon Riggs <simon(a)2ndquadrant.com> wrote:
> On Tue, 2010-04-06 at 10:09 +0300, Heikki Linnakangas wrote:
>
>> >     *  Walsender and dblink are not interruptible on win32. - related thread
>>
>> I'd actually be happy to just leave it for 9.0, but it seems like
>> consensus has been reached on how to fix it, and Fujii is working on a
>> patch, so let's follow that through.
>
> That one is a must, for me.
>
> I would put relaying easily above any of the other stuff. That is a
> truly useful feature that we are very close to being able to have in
> this release. Adding things like quotes is not moving us forwards in any
> important sense.

+1. I think this is easily the most important remaining issue that we
need to fix, with the possible exception of the shutdown checkpoint
issue.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers