Prev: [PATCH] procfs: Do not release pid_ns->proc_mnt too early
Next: [RFC][PATCH 7/8] perf: Default PMU ops
From: Jiri Kosina on 16 Jun 2010 12:10
On Wed, 9 Jun 2010, Christoph Egger wrote:

> CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all
> references for it from the source code.

The patch isn't present in linux-next as of today. I have applied it to my
tree, thanks.

>
> Signed-off-by: Christoph Egger <siccegge(a)cs.fau.de>
> ---
> arch/mips/sibyte/bcm1480/irq.c | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/arch/mips/sibyte/bcm1480/irq.c b/arch/mips/sibyte/bcm1480/irq.c
> index 044bbe4..919d2d5 100644
> --- a/arch/mips/sibyte/bcm1480/irq.c
> +++ b/arch/mips/sibyte/bcm1480/irq.c
> @@ -362,19 +362,8 @@ asmlinkage void plat_irq_dispatch(void)
> unsigned int cpu = smp_processor_id();
> unsigned int pending;
>
> -#ifdef CONFIG_SIBYTE_BCM1480_PROF
> - /* Set compare to count to silence count/compare timer interrupts */
> - write_c0_compare(read_c0_count());
> -#endif
> -
> pending = read_c0_cause() & read_c0_status();
>
> -#ifdef CONFIG_SIBYTE_BCM1480_PROF
> - if (pending & CAUSEF_IP7) /* Cpu performance counter interrupt */
> - sbprof_cpu_intr();
> - else
> -#endif
> -
> if (pending & CAUSEF_IP4)
> do_IRQ(K_BCM1480_INT_TIMER_0 + cpu);
> #ifdef CONFIG_SMP
> --
> 1.6.3.3
>

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Ralf Baechle on 29 Jun 2010 13:40
On Wed, Jun 16, 2010 at 06:00:59PM +0200, Jiri Kosina wrote:

> On Wed, 9 Jun 2010, Christoph Egger wrote:
>
> > CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all
> > references for it from the source code.
>
> The patch isn't present in linux-next as of today. I have applied it to my
> tree, thanks.

Nack. This only need to be rewired to use the ZBus profiler just like
the SB1250 already does. It's the virtually same hardware after all!

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 30 Jun 2010 05:40
On Mon, 28 Jun 2010, Ralf Baechle wrote:

> > > CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all
> > > references for it from the source code.
> >
> > The patch isn't present in linux-next as of today. I have applied it to my
> > tree, thanks.
>
> Nack. This only need to be rewired to use the ZBus profiler just like
> the SB1250 already does. It's the virtually same hardware after all!

Well, still it's dead code guarded by ifdef depending on non-exsiting
symbol ... I have just quickly tried to get a grip on the zbus thing, but

arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
1arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig: depends on SIBYTE_HAS_ZBUS_PROFILING
arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING

seem to be the only occurences in the whole tree. Another unused symbol?

So I'll revert that patch in my tree as it has been nacked by maintainer,
but the feeling that cleanup is needed is still there.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 30 Jun 2010 09:40
On Wed, 30 Jun 2010, Maciej W. Rozycki wrote:

> > Well, still it's dead code guarded by ifdef depending on non-exsiting
> > symbol ... I have just quickly tried to get a grip on the zbus thing, but
>
> You've missed...
>
> > arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
> > arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> > arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
>
> ... this:
>
> arch/mips/sibyte/Kconfig: config SIBYTE_TBPROF
> arch/mips/sibyte/Kconfig: tristate "Support for ZBbus profiling"
> > arch/mips/sibyte/Kconfig: depends on SIBYTE_HAS_ZBUS_PROFILING
>
> ^^^ here.
>
> > arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING
> >
> > seem to be the only occurences in the whole tree. Another unused symbol?
>
> Not quite so then.

Right you are, sorry for the noise.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Maciej W. Rozycki on 30 Jun 2010 09:40
On Wed, 30 Jun 2010, Jiri Kosina wrote:

> Well, still it's dead code guarded by ifdef depending on non-exsiting
> symbol ... I have just quickly tried to get a grip on the zbus thing, but

You've missed...

> arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
> arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING
> arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING

.... this:

arch/mips/sibyte/Kconfig: config SIBYTE_TBPROF
arch/mips/sibyte/Kconfig: tristate "Support for ZBbus profiling"
> arch/mips/sibyte/Kconfig: depends on SIBYTE_HAS_ZBUS_PROFILING

^^^ here.

> arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING
>
> seem to be the only occurences in the whole tree. Another unused symbol?

Not quite so then.

Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2
Prev: [PATCH] procfs: Do not release pid_ns->proc_mnt too early
Next: [RFC][PATCH 7/8] perf: Default PMU ops