Revert "writeback: limit write_cache_pages integrity scanning to current EOF"
in [Kernel]
|
Prev: [PATCH 2/3] DMAENGINE: add runtime slave control to COH 901 318
Next: trace syscalls: Clean confusing {s,r,}name and fix ABI breakage
From: Joel Becker on 29 Jun 2010 03:30 On Tue, Jun 29, 2010 at 12:27:57PM +1000, Dave Chinner wrote: > Just to clarify any possible misunderstanding here, xfs_zero_eof() > also does it's IO through the page cache for similar reasons. It's > just the mappings are found via the internal interfaces before the > zeroing is done via the anonymous pagecache_write_begin()/ > pagecache_write_end() functions (in xfs_iozero()) rather than using > the generic block functions. Mark and I discussed this some earlier this evening. I think we might be able to get away cheaper than does. In ocfs2_write_begin_nolock(), we call ocfs2_expand_nonsparse_inode() in the case of older filesystems that don't allow sparse files. That's where we handle the zeroing from old_i_size to pos for those files. I the exact same place, we could probably just detect we're about to cover the unzeroed allocation and get it there. This needs some more code eval until we're sure, and then the serious testing happens. Joel -- "Nothing is wrong with California that a rise in the ocean level wouldn't cure." - Ross MacDonald Joel Becker Consulting Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |