Review: Patch: Allow substring/replace() to get/set bit values
in [PgSql]
|
Prev: Bug ? different behaviour between 8.3 and 8.4 won ISNULL with sub arrays of nulls
Next: Bloom filters bloom filters bloom filters
From: "Kevin Grittner" on 20 Jan 2010 07:45 Leonardo F wrote: > New version of the patch, let me know if I can fix/change something > else. All issues addressed, with one tiny nit-pick -- the get_bit and set_bit methods are not part of the SQL standard. I took the liberty of removing "SQL-standard" from the documentation of these functions so that I can mark this "Ready for Committer". Thanks for the patch! -Kevin
From: Tom Lane on 25 Jan 2010 16:00
"Kevin Grittner" <Kevin.Grittner(a)wicourts.gov> writes: > Leonardo F wrote: >> New version of the patch, let me know if I can fix/change something >> else. > All issues addressed, with one tiny nit-pick -- the get_bit and > set_bit methods are not part of the SQL standard. I took the liberty > of removing "SQL-standard" from the documentation of these functions > so that I can mark this "Ready for Committer". Applied with some further editorialization. When I looked at how OVERLAY(text) was implemented, I didn't like it at all, so I took the liberty of transforming it to C code and then duplicating that implementation for bit and bytea. I doubt this would make any performance difference in simple cases, but it will have less surprise factor. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |