Review: Patch for phypot - Pygmy Hippotause
in [PgSql]
|
Prev: Fwd: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission
Next: Review: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle
From: Andrew Geery on 24 Jul 2010 06:47 It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1) the formating of the code was changed; (2) definition of the HYPOT macro was changed to use phypot rather than being removed; (3) the phypot function was declared to be extern; (4) the comments to the phypot function were changed to remove the reference about the SUS behavior. I changed the status to "Ready for Committer". Thanks Andrew On Fri, Jul 23, 2010 at 4:01 PM, Kevin Grittner <Kevin.Grittner(a)wicourts.gov> wrote: > Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > >> I think the patch is good in principle > > Since everyone seems to agree this is a good patch which needed > minor tweaks, and we haven't heard from the author, I just went > ahead and made the changes. > > Andrew, could you take another look and see if you agree I've > covered it all before it gets marked ready for a committer? > > -Kevin > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 3 Aug 2010 17:22
"Kevin Grittner" <Kevin.Grittner(a)wicourts.gov> writes: > Tom Lane <tgl(a)sss.pgh.pa.us> wrote: >> I think the patch is good in principle > Since everyone seems to agree this is a good patch which needed > minor tweaks, and we haven't heard from the author, I just went > ahead and made the changes. Applied with a bit of further editing of the comments. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |