Review: listagg aggregate
in [PgSql]
|
From: Pavel Stehule on 29 Jan 2010 02:43 2010/1/28 Tom Lane <tgl(a)sss.pgh.pa.us>: > Pavel Stehule <pavel.stehule(a)gmail.com> writes: >> with get_fn_expr_arg_stable() we are able to fix second parameter >> without some performance issues. > > No, that will create its own performance issues --- > get_fn_expr_arg_stable isn't especially cheap. > If there were a really strong reason why we had to do it, > then I'd agree, but frankly the argument for disallowing > a variable delimiter is too thin. it could be called only once. But I agree, so could be better, check it in parser time. ok - I am only one who like original behave - so I am withdrawing. Robert, If you like, please commit Itagaki's patch. + add note about behave when second parameter isn't stable. Regards Pavel Stehule > > Â Â Â Â Â Â Â Â Â Â Â Â regards, tom lane > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 29 Jan 2010 13:43 On Fri, Jan 29, 2010 at 2:43 AM, Pavel Stehule <pavel.stehule(a)gmail.com> wrote: > 2010/1/28 Tom Lane <tgl(a)sss.pgh.pa.us>: >> Pavel Stehule <pavel.stehule(a)gmail.com> writes: >>> with get_fn_expr_arg_stable() we are able to fix second parameter >>> without some performance issues. >> >> No, that will create its own performance issues --- >> get_fn_expr_arg_stable isn't especially cheap. >> If there were a really strong reason why we had to do it, >> then I'd agree, but frankly the argument for disallowing >> a variable delimiter is too thin. > > it could be called only once. But I agree, so could be better, check > it in parser time. > > ok - I am only one who like original behave - so I am withdrawing. > Robert, If you like, please commit Itagaki's patch. + add note about > behave when second parameter isn't stable. I haven't even looked at this code - I sort of assumed Itagaki was handling this one. But it might be good to make sure that the docs have been read through by a native English speaker prior to commit... ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "David E. Wheeler" on 29 Jan 2010 13:45 On Jan 29, 2010, at 10:43 AM, Robert Haas wrote: > I haven't even looked at this code - I sort of assumed Itagaki was > handling this one. But it might be good to make sure that the docs > have been read through by a native English speaker prior to commit... I did and revised them slightly. There isn't much, just a brief comment in the table of aggregate functions. The documentation for all the functions on that page could use a little love, frankly. Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 29 Jan 2010 13:46 On Fri, Jan 29, 2010 at 1:45 PM, David E. Wheeler <david(a)kineticode.com> wrote: > On Jan 29, 2010, at 10:43 AM, Robert Haas wrote: > >> I haven't even looked at this code - I sort of assumed Itagaki was >> handling this one. But it might be good to make sure that the docs >> have been read through by a native English speaker prior to commit... > > I did and revised them slightly. There isn't much, just a brief comment in the table of aggregate functions. The documentation for all the functions on that page could use a little love, frankly. Want to take a short at it? ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "David E. Wheeler" on 29 Jan 2010 13:47
On Jan 29, 2010, at 10:46 AM, Robert Haas wrote: >> I did and revised them slightly. There isn't much, just a brief comment in the table of aggregate functions. The documentation for all the functions on that page could use a little love, frankly. > > Want to take a short at it? ENOTUITS! /me is already sorely over-committed David -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |