SCSI: Support several features in arcmsr driver
in [Kernel]
|
Prev: Revert "memory-hotplug: add 0x prefix to HEX block_size_bytes"
Next: [Bug #14792] Misdetection of the TV output
From: James Bottomley on 8 Apr 2010 18:00 On Fri, 2010-04-02 at 12:01 +0800, Nick Cheng wrote: > 1. To support instantaneous report for SCSU device change by periodic > polling > 2. In arcmsr_iop_xfer(), inform AP of F/W's deadlock state to prevent > endless waiting > 3. To block the coming SCSI command while the driver is handling bus reset > 4. To support HW reset in bus reset error handler Next time, one patch per feature, please ... I still need you to redo this one (and the SCSI reset one) in a non word wrapped format so they can be applied ... just do an attachment since getting outlook to attach patches inline seems to be close to impossible. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 13 Apr 2010 16:20
On Fri, 9 Apr 2010 10:24:19 +0800 "Nick Cheng" <nick.cheng(a)areca.com.tw> wrote: > 1. To support instantaneous report for SCSI device existing by periodic > polling > 2. In arcmsr_iop_xfer(), inform AP of F/W's deadlock state to prevent > endless waiting > 3. To block the coming SCSI command while the driver is handling bus reset > 4. To support HW reset in bus reset error handler > Signed-off-by: Nick Cheng< nick.cheng(a)areca.com.tw > > > > [patch1 application/octet-stream (39.7KB)] Lots of problems here. - Two of the patches had the same title ("SCSI: Support several features in arcmsr driver"). Please ensure that each patch has a unique and well-chosen title. - application/octet-stream attachments are hard for people to read in-line in mail clients. Please at least use text/plain MIME type if possible. - The patches aren't in `patch -p1' form. You had --- arcmsr/arcmsr_attr.c +++ arcmsr.1.20.00.15-81103/arcmsr_attr.c which cannot be applied from the top-level of the kernel tree. It should have been --- a/drivers/scsi/arcmsr/arcmsr_attr.c +++ a/drivers/scsi/arcmsr/arcmsr_attr.c or similar. I got all that fixed up, but when applying the second patch (using 2.6.34-rc4) I encountered a large number of patch rejects and gave up. So please fix all that up and resend. Perhaps you could use http://savannah.nongnu.org/projects/quilt which automates all this. Also, please run scripts/checkpatch.pl across the patches - it reports rather a lot of minor issues which you might choose to address. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |