SLOB breaks Crypto
in [Kernel]
|
Prev: [RELEASE] LTTng 0.214 for kernel 2.6.33.4
Next: vlynq: make whole Kconfig-menu dependant on architecture
From: Pekka Enberg on 19 May 2010 02:00 Hi David, On Wed, May 19, 2010 at 1:40 AM, David Miller <davem(a)davemloft.net> wrote: > I don't even know of a 32-bit chip outside of x86 that doesn't > potentially emit alignment requiring 64-bit memory operations for > 64-bit objects. �So what SLOB is doing with a different default is > even more strange. �And I bet you that even without the requirement, > x86 runs faster with 64-bit alignment of 64-bit objects. Faster, sure, but SLOB is not about being fast, it's about being space efficient. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Woodhouse on 19 May 2010 03:20 On Wed, 2010-05-19 at 11:05 +1000, Herbert Xu wrote: > While this problem wouldn't have occurred, we would instead have > data corruption/alignment faults on architectures such as sparc32 > or ARM that require 64-bit alignment for 64-bit objects. Yeah, but that's what ARCH_SLAB_MINALIGN is for. ARM gets this right, and Dave has already said he's going to fix sparc. -- David Woodhouse Open Source Technology Centre David.Woodhouse(a)intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 19 May 2010 03:50 On Wed, May 19, 2010 at 08:14:28AM +0100, David Woodhouse wrote: > > Yeah, but that's what ARCH_SLAB_MINALIGN is for. > > ARM gets this right, and Dave has already said he's going to fix sparc. Right, once that gets in I will fix crypto.h so that it'll work correctly with SLOB. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Woodhouse on 19 May 2010 07:00 On Wed, 2010-05-19 at 11:05 +1000, Herbert Xu wrote: > So no getting rid of them isn't going to fix things either. Of > course I have no objections to moving this into slab.h or a similar > location should anyone be willing to do the hard work. http://git.infradead.org/users/dwmw2/minalign-2.6.git git://git.infradead.org/users/dwmw2/minalign-2.6.git Should I include the SPARC patch in that too? -- David Woodhouse Open Source Technology Centre David.Woodhouse(a)intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 19 May 2010 07:10
On Wed, May 19, 2010 at 1:58 PM, David Woodhouse <dwmw2(a)infradead.org> wrote: > On Wed, 2010-05-19 at 11:05 +1000, Herbert Xu wrote: >> So no getting rid of them isn't going to fix things either. �Of >> course I have no objections to moving this into slab.h or a similar >> location should anyone be willing to do the hard work. > > http://git.infradead.org/users/dwmw2/minalign-2.6.git > git://git.infradead.org/users/dwmw2/minalign-2.6.git Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> Are you sending the patches to Linus or do you want me to pull them in slab.git? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |