STAGING fixes and new drivers for 2.6.35-git
in [Kernel]
|
Prev: [GIT PATCH] driver core fixes for .35-git
Next: [PATCH 2/3] kobject: free memory if netlink_kernel_create() fails
From: Mike Frysinger on 4 Jun 2010 16:50 On Fri, Jun 4, 2010 at 16:44, Greg KH wrote: > apatard(a)mandriva.com (1): > staging: Add framebuffer driver for XGI chipsets does the staging tree not require properly formatted git patches ? -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mike Frysinger on 4 Jun 2010 17:10 On Fri, Jun 4, 2010 at 17:03, Greg KH wrote: > On Fri, Jun 04, 2010 at 04:48:23PM -0400, Mike Frysinger wrote: >> On Fri, Jun 4, 2010 at 16:44, Greg KH wrote: >> > apatard(a)mandriva.com (1): >> > staging: Add framebuffer driver for XGI chipsets >> >> does the staging tree not require properly formatted git patches ? > > "properly formatted" how? > > Yes, there are coding style issues in there, that's one of the reasons > it's in the staging tree :) > > Or are you referring to something else? this guy clearly hasnt set his author field. there is no proper name here, just an e-mail address. looking through the current commits in the staging tree, i see similar errors, some of which are even in the s-o-b tag. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 4 Jun 2010 17:10 On Fri, Jun 04, 2010 at 04:48:23PM -0400, Mike Frysinger wrote: > On Fri, Jun 4, 2010 at 16:44, Greg KH wrote: > > apatard(a)mandriva.com (1): > > � � �staging: Add framebuffer driver for XGI chipsets > > does the staging tree not require properly formatted git patches ? "properly formatted" how? Yes, there are coding style issues in there, that's one of the reasons it's in the staging tree :) Or are you referring to something else? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 4 Jun 2010 18:40 On Fri, 4 Jun 2010, Greg KH wrote: > > Here are a number of bugfixes for the drivers/staging tree, as well as 3 > new stand-alone drivers. The new drivers kind of obscure the diffstat > showing the other fixes due to their size. I pulled, but quite frankly, I don't want to see this kind of pull request again. There's just no _point_. I'll take new drivers outside the merge window, but there has to be some _reason_ for them. See the whole SCSI discussion a few merge windows ago. The new driver needs to improve the life of somebody to the point where I want to feel that there is a _reason_ for pulling it outside the merge window. These drivers? Not so much. Not even f*cking close. In other words: tell me why the new drivers couldn't just have waited for the next merge window? Really? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 4 Jun 2010 22:50
On Fri, Jun 04, 2010 at 03:30:40PM -0700, Linus Torvalds wrote: > > > On Fri, 4 Jun 2010, Greg KH wrote: > > > > Here are a number of bugfixes for the drivers/staging tree, as well as 3 > > new stand-alone drivers. The new drivers kind of obscure the diffstat > > showing the other fixes due to their size. > > I pulled, but quite frankly, I don't want to see this kind of pull request > again. There's just no _point_. > > I'll take new drivers outside the merge window, but there has to be some > _reason_ for them. See the whole SCSI discussion a few merge windows ago. > The new driver needs to improve the life of somebody to the point where I > want to feel that there is a _reason_ for pulling it outside the merge > window. Fair enough, I shouldn't have added them to the request this time, sorry. > These drivers? Not so much. Not even f*cking close. > > In other words: tell me why the new drivers couldn't just have waited for > the next merge window? Really? They could have, sorry, will not do it again. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |