Prev: [PATCH v2 2/3] ipmi: Convert tracking of the ACPI device pointer to a PNP device
Next: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70
From: Casey Schaufler on 13 Mar 2010 14:40
wzt.wzt(a)gmail.com wrote:
> In smk_import_entry(), smack[i] = '\0' was set if found = 1, so:
> if (found)
> smack[i] = '\0';
> No need to continue again, just can break the loop.
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt(a)alibaba-inc.com>
>
Nacked-by: Casey Schaufler <casey(a)schaufler-ca.com>
> ---
> security/smack/smack_access.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
> index 0f9ac81..0e064e8 100644
> --- a/security/smack/smack_access.c
> +++ b/security/smack/smack_access.c
> @@ -318,7 +318,7 @@ struct smack_known *smk_import_entry(const char *string, int len)
>
> for (i = 0, found = 0; i < SMK_LABELLEN; i++) {
> if (found)
> - smack[i] = '\0';
> + break;
> else if (i >= len || string[i] > '~' || string[i] <= ' ' ||
> string[i] == '/' || string[i] == '"' ||
> string[i] == '\\' || string[i] == '\'') {
>
The intention of this code is to fill the label. Yes, I could zero the
target in advance and break here but would that be significantly better?
I don't see that it would be. In any case, the change you suggest would
not suffice by itself.

Are you looking for a real project to work on? I could suggest a
thing or two that would be much more welcome than these attempts
at pointless code change.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v2 2/3] ipmi: Convert tracking of the ACPI device pointer to a PNP device
Next: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70