Prev: [BUG] perf_event: crash in perf_output_begin
Next: [PATCH v2] i2c-bfin-twi: handle faulty slave devices better
From: Charles Clément on 10 May 2010 11:40
Hello Mark,

On Mon, May 10, 2010 at 05:36:57PM +0800, Mark wrote:
> This patch fixes lots of long line lengths in comedi_fops.c found by
> checkpatch.pl
>
> Signed-off-by: Mark Rankilor <reodge(a)gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 38 ++++++++++++++++++++++-----------
> 1 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index e7095d7..9bfab73 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -962,7 +962,8 @@ static int do_insn_ioctl(struct comedi_device *dev,
> if (ret < 0)
> goto error;
> if (insn.insn & INSN_MASK_READ) {
> - if (copy_to_user(insn.data, data, insn.n * sizeof(unsigned int))) {
> + if (copy_to_user
> + (insn.data, data, insn.n * sizeof(unsigned int))) {

I think it'd be better to keep the opening parenthesis on the same line
of the function and maybe the first argument, too.

>
> _______________________________________________
> devel mailing list
> devel(a)linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

--
Charles Cl�ment

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mark Rankilor on 10 May 2010 20:40
2010/5/10 Charles Cl�ment <caratorn(a)gmail.com>:
> I think it'd be better to keep the opening parenthesis on the same line
> of the function and maybe the first argument, too.

Charles, I agree with you here. I did it this way since there is a
very similar line in the code paragraph above it, so I figured I'd
stay consistent.

I'll revisit this and change both of them to be in the style you suggested.

Cheers,
Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [BUG] perf_event: crash in perf_output_begin
Next: [PATCH v2] i2c-bfin-twi: handle faulty slave devices better